(→Skill List Improvement: Spacing error) |
@DeletedUser40281524 (talk | contribs) |
||
Line 33: | Line 33: | ||
} |
} |
||
: Thanks in advance. Please check out [[MediaWiki_talk:Mobile.css]] as well. [[User:Molldust|Molldust]] ([[User talk:Molldust|talk]]) 03:40, 26 December 2015 (UTC) |
: Thanks in advance. Please check out [[MediaWiki_talk:Mobile.css]] as well. [[User:Molldust|Molldust]] ([[User talk:Molldust|talk]]) 03:40, 26 December 2015 (UTC) |
||
+ | ::Done! -[[User:RJackson|<span class="modbg" style="margin-right:1px;text-shadow: #538237 1px 1px 0px;">RJ</span>]] 20:49, 26 December 2015 (UTC) |
Revision as of 20:49, 26 December 2015
Gradient error
The selector .mp-content-header-alt, .mp-title-gradient contains #d95d410%, which should say #d95d41 0% instead. Could be thrown out all together, because gradients are now supported by all browsers without prefix since longer. Noticed while I tried to figure out why the skilllist css takes so long to update. Molldust (talk) 00:36, 19 December 2015 (UTC)
- I've removed the vendor prefixed usages of
linear-gradient
. Thanks for pointing this out! -RJ 00:42, 19 December 2015 (UTC)
Skill List Improvement
I figured out that float: left; in the li.skilllist-lite selector causes elements to stack within the same line if the height differs. Replacing it with display: inline-block; fixes that.
Elements still don't force 100% height per line. There is currently no practical workaround for this [1] and hope this is acceptable. Molldust (talk) 10:08, 19 December 2015 (UTC)
- li.skilllist-lite requires vertical-align: top; as well for a complete fix. Sorry for bothering. Molldust (talk) 10:17, 19 December 2015 (UTC)
- Urgent update required! I added column support so you don't have to specify the width in each element. See User:Molldust/common.css. No need to take over the float:none; for the respective selector, just delete the float:left; part.
- Defaults to 100% currently, but I will change it to 50% then. This is independent from the CSS though, that's the nice part of it. It only defines the layout, which one is used is decided ultimately on the templates.
- Some admin needs to update this CSS though, otherwise the layouts are not available ;) Molldust (talk) 22:42, 19 December 2015 (UTC)
- I have updated the CSS with your tweaks, Molldust. On top of that I have also added a flexbox implementation of the desired layout, which should look & perform better for visitors using browsers that support Flexbox. Thanks! -RJ 01:37, 20 December 2015 (UTC)
- Fyi, now it's not possible to specify the width directly within SkillListLite anymore, so I gonna remove that functionality. It gets overwritten by the default flex/column parameter in SkillListHead. Bless you for getting the vertical fill so fast, I already gave up on that. Molldust (talk) 01:52, 20 December 2015 (UTC)
- New CSS is available for the Template:SkillListRich and Template:SkillListHead, which now has a title/collapse function. Current discussion can be found at Dota_2_Wiki:Discussion#Skillbox_Minimal. The proposal for the latest Common.css is on Pastebin. The mobile version does not differ between col amounts to respect the small screen. The diff is as usual on User:Molldust/common.css. Happy holidays! Molldust (talk) 13:53, 25 December 2015 (UTC)
- Updated! Thanks -RJ 16:31, 25 December 2015 (UTC)
- Thank you very much for adding the CSS, RJ! Unfortunately I made a spacing error that needs fixing: max-width: calc(100%-74px) is taken as a full string instead of an operation. The fix:
div.skilllist-rich-desc { max-width: calc(100% - 74px); }
- Thanks in advance. Please check out MediaWiki_talk:Mobile.css as well. Molldust (talk) 03:40, 26 December 2015 (UTC)
- Done! -RJ 20:49, 26 December 2015 (UTC)